Fix: Default values bypass min/max validation in utils/validation.get_int/get_float - #1664
Merged
steam-bell-92 merged 1 commit intoJul 12, 2026
Merged
Conversation
|
@Kirtan-pc is attempting to deploy a commit to the Anuj's projects Team on Vercel. A member of the Team first needs to authorize it. |
steam-bell-92
added
type:bug
Contributor
|
🎉 Thank you for your contribution! Your Pull Request has been merged successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Summary
Fix
get_int()andget_float()inutils/validation.pyto validate thedefaultparameter againstmin_value/max_valuebefore returning it. Previously, an out-of-range default (e.g.,get_int("Enter: ", min_value=0, max_value=10, default=999)) was returned immediately when the user entered empty input, bypassing range validation and potentially introducing invalid state.Changes
utils/validation.pyget_int(): Before returning the default on empty input, validate it againstmin_valueandmax_value. If out of range, print an error message and continue the prompt loop.get_float(): Same fix applied — validate the default againstmin_value/max_valuebefore returning it on empty input.</｜DSML｜parameter>
</｜DSML｜invoke>
</｜DSML｜tool_calls>
🔗 Linked Issue
Closes #1545
📋 Contribution Checklist